Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add DialContext and EnrollContext for Client #543

Merged
merged 8 commits into from
Mar 19, 2024
Merged

feat: add DialContext and EnrollContext for Client #543

merged 8 commits into from
Mar 19, 2024

Conversation

leslie-fei
Copy link

@leslie-fei leslie-fei commented Mar 13, 2024 •
edited by panjf2000
Loading

Fixes #541

panjf2000
panjf2000 requested changes Mar 14, 2024
View reviewed changes
client_unix.go Outdated Show resolved Hide resolved
client_unix.go Outdated Show resolved Hide resolved
client_test.go Outdated Show resolved Hide resolved
@panjf2000 panjf2000 changed the title opt: client dial with context feat: add DialContext and EnrollContext for Client Mar 14, 2024
@leslie-fei
Copy link
Author

都改掉提交了

panjf2000
panjf2000 requested changes Mar 15, 2024
View reviewed changes
Copy link
Owner

@panjf2000 panjf2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

startGnetClient 函数现在不需要 ev 了，直接移除掉吧。

还有其他的代码格式化问题也一起解决掉吧，不然 golangci-lint 会报错。

panjf2000
panjf2000 reviewed Mar 18, 2024
View reviewed changes
client_test.go Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Mar 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.00%. Comparing base (f6b0d30) to head (fa1e739).
Report is 6 commits behind head on dev.

Files Patch % Lines
client_unix.go 83.33% 1 Missing ⚠️
client_windows.go 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #543      +/-   ##
==========================================
- Coverage   79.12%   79.00%   -0.12%     
==========================================
  Files          25       25              
  Lines        2074     2091      +17     
==========================================
+ Hits         1641     1652      +11     
- Misses        299      304       +5     
- Partials      134      135       +1
Flag Coverage Δ
unittests 79.00% <86.66%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leslie-fei
Copy link
Author

leslie-fei commented Mar 18, 2024 •
edited
Loading

存在的几个data race问题我也修复了下

@panjf2000
Copy link
Owner

你本地测过了没有？

@leslie-fei
Copy link
Author

测过了

panjf2000
panjf2000 requested changes Mar 18, 2024
View reviewed changes
client_test.go Outdated Show resolved Hide resolved
client_test.go Outdated Show resolved Hide resolved
client_test.go Show resolved Hide resolved
@leslie-fei
Copy link
Author

改过了, 你看看

panjf2000
panjf2000 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Owner

@panjf2000 panjf2000 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@panjf2000 panjf2000 merged commit 54f81b6 into panjf2000:dev Mar 19, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panjf2000 panjf2000 panjf2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: 为 Client.Enroll/Dial 提供同步 callback
2 participants
@leslie-fei @panjf2000